[format] Use AlignFunctionDeclarations from clang-format 20.1.0 #19753
+249
−219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 22 files 22 suites 3d 15h 33m 2s ⏱️ Results for commit 2d84412. ♻️ This comment has been updated with latest results. |
vepadulano
reviewed
Aug 27, 2025
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
I would personally favour this move 👍
pcanal
force-pushed
the
align-function
branch
2 times, most recently
from
88da441 to
c1ea1ff
Compare
pcanal
force-pushed
the
align-function
branch
from
c1ea1ff to
2d84412
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang-format v20.1.0 and above have a new sub-option
AlignFunctionDeclarations(part of the optionAlignConsecutiveDeclarations) (see https://clang.llvm.org/docs/ClangFormatStyleOptions.html).This PR was made to see how clang-formatting some of the core ROOT source would look like with it.
The alignment of functions is actually pretty close to what we expect/want.
However the enums declaration might still benefit from
AlignConsecutiveAssignmentsbut it would apply to all assignment (which has been controversial).Ubuntu 24 does not have clang-format v20 and thus a bit a gymnastic was needed to install it.
The new sub-option is fatal to older version of clang-format, so we would all be required to use/install clang-format v20 and newer (v21 was just released on August 26).